Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with NA returns from detectCores #150

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Deal with NA returns from detectCores #150

merged 1 commit into from
Apr 28, 2024

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Jan 15, 2024 •
edited
Loading

parallel::detectCores() may return NA in cases that it fails to guess. In those cases we want to use the default.

> min(2,NA)
# [1] NA
> min(2,NA, na.rm=TRUE)
#  [1] 2

eddelbuettel
eddelbuettel approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@eddelbuettel eddelbuettel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@aadler
Copy link
Contributor

aadler commented Feb 13, 2024

@astamm This should be merged.

@aadler
Copy link
Contributor

aadler commented Apr 28, 2024

Nudge, nudge @astamm :)

@astamm
Copy link
Owner

astamm commented Apr 28, 2024

Thanks!

@astamm astamm merged commit f74ca93 into astamm:master Apr 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddelbuettel eddelbuettel eddelbuettel approved these changes

@aadler aadler aadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeroen @aadler @astamm @eddelbuettel